Bug #461
Added by Anonymous over 5 years ago.
Updated over 5 years ago.
Description
Photo gallery feature images are appearing fine on entertainment.ie/photos/ but I'm getting an error page when trying to view the individual gallery (see image attached)
See below for error page
https://www-dev.entertainment.ie/photos/memorable-award-show-moments-473678/
Steps taken to create gallery:
- Create new post, set post format to gallery and category to photo galleries
- Add gallery block, choose images from media library. Hit create gallery and select images.
- Hit create a new gallery, reorder images and insert gallery into post.
- Add tags, keyphrases, featured image etc as I normally would before publishing live.
Files
- Status changed from New to Feedback
- Assignee set to David Bryan
Hi Maeve!! I found a problem indeed, it's fixed now. I've added a Gutemberb Galerry Block Support. Now, OLD Galleries and NEW Galleries will work fine.
Maeve's gallery (Memorable Award Show)... I saw that you created 2 days ago and, you left a second gallery block with no images. After removing, worked ok.
We need to test it more anyway, that was a significant update in the GalleryFormatter file.
Hey Newton
Reopening this ticket to log an issue.
While the galleryFormatter seems to be working very well, it's also adding an MPU div to inline gallery blocks within ordinary articles, where they shouldn't be.
See attached screenshot.
Thanks
-P
Hmm... the problem is weirder than that, it's actually all the images from the inline galleries from the content and repeating them at the bottom in a gallery, which we don't want to happen in ordinary articles!
If it's a longform article this doesn't happen
Does it just mean we should remove this from the article.blade.php?
@if (array_get($post, 'gallery'))
@include('photos.partials.posts-gallery', ['title' => $post['title'], 'gallery' => $post['gallery'], 'social' => $post['social']])
@endif
- Assignee changed from Newton Duarte to Pierce Gleeson
- Status changed from In Progress to Feedback
- Assignee changed from Pierce Gleeson to David Bryan
Okay, mega update to galleries today, removed the GalleryFormatter condensed gallery from the bottom of the articles as suggested above, rarely used and no longer relevant with gutenburg.
Rewrote the ContentFormatters to output images of appropriate size (lots of regex).
Implemented lightbox on the inline gutenburg galleries when people have clicked "link to media" so each image gallery can have it's own lightbox gallery once you click.
Need to talk about image captions in galleries, whether to hide them or what.
- Status changed from Feedback to Closed
ok great stuff thanks - closing
Also available in: Atom
PDF
